Fix desktop-gui layout issues when there's a plugins file error#4962
Merged
jennifer-shehane merged 1 commit intodevelopfrom Aug 9, 2019
Merged
Fix desktop-gui layout issues when there's a plugins file error#4962jennifer-shehane merged 1 commit intodevelopfrom
jennifer-shehane merged 1 commit intodevelopfrom
Conversation
chrisbreiding
changed the title
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
|
||
| .full-alert { | ||
| // `margin: auto` fixes issue with flexbox vertically-centered element + oveflow | ||
| // https://stackoverflow.com/questions/33454533/cant-scroll-to-top-of-flex-item-that-is-overflowing-container |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No longer covers nav and footer when the error details are expanded:
Bonus: caps the height of the error details and scrolls them instead of the entire error message so 'Try Again' button stays visible (as long as desktop gui height is at a reasonable size):
Pre-merge Tasks